Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 蜡烛图切换销毁scrollbar时移除对应事件 #1920

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: 蜡烛图切换销毁scrollbar时移除对应事件 #1920

merged 2 commits into from
Jan 5, 2024

Conversation

ICMI
Copy link
Contributor

@ICMI ICMI commented Jan 4, 2024

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@ICMI ICMI requested a review from zengyue January 4, 2024 08:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited
Loading

Fails
🚫

node failed.

Log

Error:  ReferenceError: Cannot access 'artifact' before initialization
    at dangerfile.js:29:9
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
danger-results://tmp/danger-results-f066a9bf.json

Generated by 🚫 dangerJS against 6e323ca

zengyue
zengyue reviewed Jan 4, 2024
View reviewed changes
packages/f2/src/components/zoom/index.tsx
this.onStart();
onPanStart({ scale });
});
Copy link
Member

@zengyue zengyue Jan 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接把这段定义成成员方法吧，直观点

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实外部已经有对应的方法了，onPanStart, onEnd等，但是不能直接用。在外面再包个方法感觉很费功夫，要和原来已有的区分开，又不能影响功能。

@zengyue zengyue merged commit e70b36a into master Jan 5, 2024
9 of 11 checks passed
@zengyue zengyue deleted the fix-scrollbar-unmount branch January 5, 2024 01:42
zengyue pushed a commit that referenced this pull request Jan 5, 2024
@ICMI @zengyue
fix: 蜡烛图切换销毁scrollbar时移除对应事件 (#1920)
0a6e7e1 
* fix: 蜡烛图切换销毁scrollbar时移除对应事件

---------

Co-authored-by: 兵人 <xuezhiqiang.xzq@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyue zengyue zengyue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ICMI @zengyue