Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

在设置limitInPlot为true时，代码此处未做非空判断，导致空指针图标无法显示 #458

Closed
YueQuanXiaoChe opened this issue Dec 18, 2018 · 3 comments
Closed

在设置limitInPlot为true时，代码此处未做非空判断，导致空指针图标无法显示 #458

YueQuanXiaoChe opened this issue Dec 18, 2018 · 3 comments
Assignees
@simaQ
Milestone
3.3.2

Comments

@YueQuanXiaoChe
Copy link

YueQuanXiaoChe commented Dec 18, 2018 •
edited
Loading

https://github.com/antvis/f2/blob/5d1ac5e460e3d5f8e93cfccaf1df23715ee69a6b/src/component/guide/point.js#L19

设置limitInPlot为true时，代码此处未做非空判断，导致空指针图标无法显示
@YueQuanXiaoChe
Copy link
Author

在chart.guide().point时设置limitInPlot为true时，代码此处未做非空判断，导致空指针报错，且point无法显示

@simaQ
Copy link
Contributor

simaQ commented Dec 18, 2018

欢迎提 PR

@simaQ simaQ mentioned this issue Dec 19, 2018
Merged
3 tasks
@simaQ simaQ added this to the 3.3.2 milestone Dec 19, 2018
@simaQ simaQ self-assigned this Dec 19, 2018
@simaQ simaQ closed this as completed in 2edbb03 Dec 19, 2018
@simaQ
Copy link
Contributor

simaQ commented Dec 20, 2018

已修复，请将 F2 更新至最新版。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simaQ simaQ

Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

No branches or pull requests
2 participants
@simaQ @YueQuanXiaoChe