Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: faster getImageData #1370

Merged
merged 2 commits into from
Jun 13, 2023
Merged

perf: faster getImageData #1370

merged 2 commits into from
Jun 13, 2023

Conversation

1wkk
Copy link
Contributor

@1wkk 1wkk commented Jun 12, 2023

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

💡 Background and solution

Canvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true. See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xiaoiver xiaoiver self-assigned this Jun 13, 2023
@xiaoiver
Copy link
Contributor

在 WebGL / WebGPU 绘制 Text 时生成 SDF，Chrome 也会提示相同的内容：

截屏2023-06-13 上午10 04 42

@xiaoiver xiaoiver merged commit fee038a into antvis:next Jun 13, 2023
@1wkk 1wkk mentioned this pull request Jun 19, 2023
Closed
@xiaoiver
Copy link
Contributor

🎉 This PR is included in version @antv/g-lite-v1.1.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version 1.8.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version @antv/g-plugin-device-renderer-v1.8.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version 1.8.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version @antv/g-lite-v1.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version @antv/g-plugin-device-renderer-v1.8.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version @antv/g-lite-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@xiaoiver
Copy link
Contributor

🎉 This PR is included in version @antv/g-plugin-device-renderer-v1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TsMask TsMask mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xiaoiver xiaoiver

Labels
enhancement released on @alpha released on @beta released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1wkk @xiaoiver