Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

工程改进建议 #81

Closed
5 tasks
hustcc opened this issue May 7, 2022 · 3 comments
Closed
5 tasks

工程改进建议 #81

hustcc opened this issue May 7, 2022 · 3 comments
Assignees

Comments

@hustcc
Copy link
Member

hustcc commented May 7, 2022

可以直接基于这个模板:https://github.com/antvis/template

@mxz96102
Copy link
Member

mxz96102 commented May 7, 2022

  • register 和 unregister 是原来G6原有的概念,所以应该可以拆除
  • 关于 g-webgpu 的话,可以考虑维护 layout 和 layout-gpu两个包,按需引用
  • 因为是个break change,不如直接来维护成 1.0.0

@hustcc
Copy link
Member Author

hustcc commented May 7, 2022

可以的,layout 就组成各种图布局算法的函数库。另外,类似的 graphlib 在工程上也注意些类似的问题~~

@jtsang4
Copy link
Member

jtsang4 commented May 10, 2022

这个代码的设计上是否可以去掉 register 和 unregister 的概念,全部保持是纯函数的代码片段,并设置 sideEffects: false

这个包体积还是挺大的,强烈支持最后一点,方便使用者可以 tree shaking 掉没有使用的特性。

@hustcc hustcc closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants