Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen fix #367

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Fullscreen fix #367

wants to merge 5 commits into from

Conversation

DDR0
Copy link
Contributor

@DDR0 DDR0 commented Sep 17, 2023 •
edited

Fixes #368.

rkettering and others added 4 commits July 24, 2023 01:15
@rkettering
Fixing an issue where objects which were in a fatal collision state w…
38341b8 
…ith other objects were not throwing the FFL exception that they're supposed to throw to allow us to gracefully recover, and were instead just asserting the game. Notably, this was causing a frogatto issue when moth bombers would drop a bomb through other moth bombers, and assert if said bomb overlapped another one as it was spawned.
@DDR0
Moved fullscreen logic to screen_handling in prep for a fix.
6b06892 
It needs to be further moved to WindowManager instead of screen_handling, to be beside `bool setWindowSize`.
@DDR0
Added external/ folder to gitignore, a Windows build artefact I think.
5af3c9d
@DDR0
Made fullscreen mode in the esc menu work. Converted from dropdown → …
44e4bae 
…checkbox.
@DDR0 DDR0 added Bug New Rendering Engine Regression Anura Issue Graphical / Glitch Visual abnormalities, corruption, and other visually ugly stuff. labels Sep 17, 2023
@DDR0 DDR0 added this pull request to the merge queue Dec 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 11, 2023
@Rotonen
Copy link
Contributor

Rotonen commented Dec 11, 2023

This has a conflict with one of the other PRs, which went in before this did. Needs manual resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkettering rkettering rkettering approved these changes

Assignees

@rkettering rkettering

Labels
Anura Issue Bug Graphical / Glitch Visual abnormalities, corruption, and other visually ugly stuff. New Rendering Engine Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullscreen dropdown in the esc menu video options doesn't work.
3 participants
@DDR0 @Rotonen @rkettering