Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggable options doesn't work on StickyWin.PointyTip. Included Fix #68

Open
appaulo14 opened this issue Jul 9, 2010 · 4 comments
Open

Comments

@appaulo14
Copy link

What Steps will reproduce the problem?:
Create a StickyWin.PointyTip with the "draggable" option set to true.

What is the expected output? What do you see instead?
The PointyTip box should be draggable. It is not.

Fix
I used Class.refactor to put a class to makeDraggable() and makeResizable() into the constructor.

StickyWin.PointyTip = Class.refactor(StickyWin.PointyTip,{
'initialize': function(){
this.previous.apply(this, arguments);
if (this.options.draggable) this.makeDraggable();
if (this.options.resizable) this.makeResizable();
}
});

@anutron
Copy link
Owner

anutron commented Jul 10, 2010

Why would you want a tool tip to be draggable? I can't think of a UI I have ever used with a roll-over tip that I could drag around...

@appaulo14
Copy link
Author

I work in a business environment where we are required to use a modified version of IE6 that is even more difficult to work with than regular IE6. IFrameShim doesn't overlay drop drown lists properly in it, for example. Mainly, I enabled dragging to make sure that part of tool tip didn't get hidden off-screen or buried under drop down lists. The tool tip contains a small table of data so it is important to see the whole thing.

I see what you're saying though. If I was developing on a modern browser it probably wouldn't be necessary. I figured since the draggable option was still in the StickyWin.PointyTip class that I would post it here.

@anutron
Copy link
Owner

anutron commented Jul 11, 2010

Looking at the code, it looks to me like it should be draggable. StickyWin.Drag uses Class.refactor to change StickyWin, which StickyWin.PointyTip extends. I'm not sure why it isn't working. Can you look and see if you have StickyWin.Drag included before or after StickyWin.PointyTip (and to confirm you have it at all). If you do, try moving it to the other position (above it if it's below it now, other wise below it).

@appaulo14
Copy link
Author

I have the entire Clientcide library, mootools more, and mootools (of course).

StickyWin.PointyTip is after StickyWin.Drag by default. Moving it to before has no effect.

I believe it is because the setContent method of StickyWin.PointyTip doesn't call this.parent, since the setContent of StickyWin.Drag calls this.makeDraggable().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants