Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For megaraid parsing, use /c0 show instead of /c0/dall show. #100

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

smoser
Copy link
Collaborator

@smoser smoser commented Apr 1, 2021

For megaraid cards that do not support raid (true story), the
/c0/dall request will return Un-supported. But you can still get the
same information from the 'storcli /c0 show'.

Fixes #98.

@smoser smoser force-pushed the fix/unsupported-raid-cards branch from 793f664 to 43216f8 Compare April 1, 2021 19:41
@smoser
Copy link
Collaborator Author

smoser commented Apr 1, 2021

this is mostly a replacement of #99.

@smoser smoser requested a review from raharper April 1, 2021 19:41
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #100 (f043aaa) into master (8caf2cd) will decrease coverage by 0.22%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   64.36%   64.13%   -0.23%     
==========================================
  Files          16       16              
  Lines        1706     1712       +6     
==========================================
  Hits         1098     1098              
- Misses        440      445       +5     
- Partials      168      169       +1     
Impacted Files Coverage Δ
megaraid/linux.go 0.00% <ø> (ø)
megaraid/megaraid.go 63.15% <ø> (-21.06%) ⬇️
linux/system.go 37.50% <50.00%> (+0.60%) ⬆️
megaraid/storcli.go 66.42% <70.83%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8caf2cd...f043aaa. Read the comment docs.

For megaraid cards that do not support raid (true story), the
/c0/dall request will return Un-supported.  But you can still get the
same information from the 'storcli /c0 show'.

Fixes project-machine#98.
@smoser smoser force-pushed the fix/unsupported-raid-cards branch from 43216f8 to f043aaa Compare April 2, 2021 02:02
@smoser smoser merged commit 4bfa793 into project-machine:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to query megaraid UCSC-SAS-M5HD
2 participants