Show virt-id in demo output if 'name' is empty. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 53.86% 53.86%
=======================================
Files 16 16
Lines 1888 1888
=======================================
Hits 1017 1017
Misses 772 772
Partials 99 99 Continue to review full report at Codecov.
|
The 'name' field of a virtual drive may be empty. If that is the
case, show 'virtid-<num>' in output of 'megaraid disk-summary'.
Before:
$ ./demo megaraid disk-summary
Path | Name | Type | State |
/dev/sda | | HDD | Optl |
After:
$ ./demo megaraid disk-summary
Path | Name | Type | State |
/dev/sda | virtid-0 | HDD | Optl |
smoser
force-pushed
the
fix/megaraid-virt-empty-name
branch
from
1ed7444
to
f967a01
Compare
tych0
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'name' field of a virtual drive may be empty. If that is the
case, show 'virtid-' in output of 'megaraid disk-summary'.
Before:
After: