-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving Costmap2DConverter.hpp breaks downstream packages #111
Comments
Thanks for the notice @tfoote! I just added the backward compatibility in https://github.com/ethz-asl/grid_map/pull/112. I'll merge this and create a new version with the hope to fix things asap. Let me know if there's anything else I can do. |
Peter, I can update cost_map to accomodate the moved header on the weekend.
…On 25 July 2017 at 04:54, Péter Fankhauser ***@***.***> wrote:
Thanks for the notice @tfoote <https://github.com/tfoote>! I just added
the backward compatibility in #112
<https://github.com/ethz-asl/grid_map/pull/112>. I'll merge this and
create a new version with the hope to fix things asap. Let me know if
there's anything else I can do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/ethz-asl/grid_map/issues/111#issuecomment-317673774>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAp9EqPtdgEjwQ1SZu_EKskBP0v8uA11ks5sRa1UgaJpZM4Oh69t>
.
--
Phone : +82-10-5400-3296 (010-5400-3296)
Home: https://snorriheim.atlassian.net/wiki/spaces/~snorri
<http://snorriheim.dnsdojo.com/>
<http://rnd.yujinrobot.com/>
|
Thanks for the quick fix @pfankhauser it looks like this is fixing the regressions. Once the rebuild is complete I think we'll be ready to sync. |
@pfankhauser |
Ok great, thanks @stonier! |
The recent moving of the include file: ethz-asl@787747e in #96 is breaking downstream packages expecting the header.
A backwards compatibility header with a deprecation warning would be appreciated.
http://build.ros.org/view/Ibin_uT64/job/Ibin_uT64__cost_map_ros__ubuntu_trusty_amd64__binary/8/console
The text was updated successfully, but these errors were encountered: