Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on how data is obtained #16

Closed
humzaiqbal opened this issue Feb 27, 2021 · 1 comment
Closed

Clarification on how data is obtained #16

humzaiqbal opened this issue Feb 27, 2021 · 1 comment

Comments

@humzaiqbal
Copy link

Hi, thanks a lot for the great repo! One question, I notice that in all.py you have the following line,

shotid_tmp = 0
for shotid in shotid_list:
if int(shotid) < shotid_tmp+seq_len_half:
continue

does that mean you only train / run inference on shots that can be fully covered by the window length divided by 2? (Ie the 1st and 2nd shot of a movie would not be trained on at all with a window size of 4 and half window size 2). Also if thats the case then what about the shots at the very end (the last and second to last shot with the same window sizes as above) Trying to understand how the data is fed into the model, thanks!

@AnyiRao
Copy link
Owner

AnyiRao commented Aug 24, 2021

Yes @humzaiqbal, what you understand is right. Since we adopt sliding windows in our model, the very start and end cannot be handled. To handle them, it is suggested to train another model with a small sliding window to specially process these cases.

@AnyiRao AnyiRao closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants