Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fetch API #745

Closed
hahanein opened this issue Jan 27, 2023 · 8 comments
Closed

Add Fetch API #745

hahanein opened this issue Jan 27, 2023 · 8 comments
Assignees
Labels
fetch Fetch client related issue
Milestone

Comments

@hahanein
Copy link

Would you be interested in a pull request adding the Fetch API as a standard client?

@gkweb
Copy link
Contributor

gkweb commented Feb 8, 2023

Please add 👀

@anymaniax
Copy link
Collaborator

Hello guys, you can use a mutator to do that. Just like this.

@meixger
Copy link

meixger commented Feb 8, 2023

Very happy with the mutator. Works great with within Nuxt 3!

@gkweb
Copy link
Contributor

gkweb commented Feb 8, 2023

There is actually an example of a custom client using fetch in the docs like shared above.

https://orval.dev/guides/custom-client

@hahanein
Copy link
Author

A guide for creating a custom client is a lot less convenient than an option. Currently, this makes axios the de facto standard client. It sends a wrong signal to users: Generally, you should be using axios. When really, you probably will not need it. In this day and age Fetch is a great API. In some cases Fetch even supports features axios does not. Like Keep-Alive.

@michalusio
Copy link

Agree with @hahanein.
The default options should require no additional packages, and so Fetch should be the default.

@anymaniax
Copy link
Collaborator

We could for sure add a fetch client directly but for the moment it cannot be the default client since it would be a breaking change

@melloware melloware added the fetch Fetch client related issue label Jun 18, 2024
@melloware
Copy link
Collaborator

Fetch was added with this PR: #1353

@melloware melloware added this to the 6.30.0 milestone Jun 18, 2024
@melloware melloware modified the milestones: 6.30.0, 6.32.0 Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetch Fetch client related issue
Projects
None yet
Development

No branches or pull requests

7 participants