Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swr mutation fetcher - name param __ in case of no body arg #1263

Merged

Conversation

AffeJonsson
Copy link
Contributor

Status

READY

Description

Fixes #1261 by naming the parameter __ when it is not used in the function

Related PRs

N/A

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

  1. yarn build
  2. cd tests
  3. yarn generate:swr
  4. generated code should contain a getDeletePetByIdMutationFetcher function containing __: { arg: Arguments } and a getCreatePetsMutationFetcher function containing { arg }: { arg: Arguments }

@AffeJonsson AffeJonsson changed the title fix: name param __ in case of no body arg fix: swr mutation fetcher - name param __ in case of no body arg Mar 15, 2024
@melloware melloware added this to the 6.26.0 milestone Mar 15, 2024
@melloware melloware added the bug Something isn't working label Mar 15, 2024
@soartec-lab soartec-lab self-assigned this Mar 15, 2024
@soartec-lab
Copy link
Member

@AffeJonsson
Thank you. Please wait a moment while I check this.

Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for great job !

@soartec-lab soartec-lab merged commit 77d10b4 into orval-labs:master Mar 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT/DELETE/POST methods without body generates unused code when generating for SWR
3 participants