Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): update samples to v5 and fix type issue #1268

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

Maxim-Mazurok
Copy link
Contributor

Status

READY

Description

Updated vue-query to v5 in samples, and had to make a queryOptions.queryKey -> unref(queryOptions).queryKey fix for it to compile.

Without it:
image


Also I tried to update to v5 in tests, but I'm getting errors like this:

generated/vue-query/tags/pets.ts:270:14 - error TS2742: The inferred type of 'useDeletePetById' cannot be named without a reference to '@tanstack/vue-query/node_modules/@tanstack/query-core/build/legacy/queryClient-6vLRMq5C'. This is likely not portable. A type annotation is necessary.

270 export const useDeletePetById = <TError = AxiosError<Error>,

and I have no idea how to fix it.
I feel like the whole idea is to use inferred type instead of re-defining it... Anyway, we can leave it for later I guess.

Copy link
Collaborator

@anymaniax anymaniax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks seems good

@anymaniax anymaniax merged commit c9834b6 into orval-labs:master Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants