Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a sample app that uses the fetch client with NextJS #1407

Merged

Conversation

soartec-lab
Copy link
Member

@soartec-lab soartec-lab commented May 29, 2024

Status

Ready

Description

follow up to #1387

I add a sample app that uses the fetch client with NextJS

Related PRs

#1353

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

cd next-app-with-fetch/
yarn dev

@soartec-lab soartec-lab force-pushed the chore/add-next-fetch-sample-app branch from a47ad17 to 17dc153 Compare June 6, 2024 00:15
@soartec-lab soartec-lab marked this pull request as ready for review June 7, 2024 00:16
@soartec-lab soartec-lab force-pushed the chore/add-next-fetch-sample-app branch from 1d15811 to cd91310 Compare June 9, 2024 23:25
@soartec-lab soartec-lab added this to the 6.31.0 milestone Jun 9, 2024
@soartec-lab soartec-lab linked an issue Jun 9, 2024 that may be closed by this pull request
7 tasks
@soartec-lab
Copy link
Member Author

@melloware @anymaniax
This PR is for Lite, which adds a sample app. Could you review this ?

@@ -27,3 +27,5 @@ You can find below some samples
- [nx fastify react](https://github.com/anymaniax/orval/tree/master/samples/nx-fastify-react)
- [angular app](https://github.com/anymaniax/orval/tree/master/samples/angular-app)
- [hono](https://github.com/anymaniax/orval/tree/master/samples/hono)
- [next app with fetch](https://github.com/anymaniax/orval/tree/master/samples/next-app-with-fetch)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like you copied this line twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, that's right.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by bellow:

9399754

@soartec-lab
Copy link
Member Author

The failed "CI" is fixed at #1450

@melloware melloware merged commit 8efb741 into orval-labs:master Jun 11, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support fetch client
2 participants