-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Error Handling for keytarSet and keytarGet #804
Comments
I think we should consider about finding an alternative to the keytar package, as it is no longer maintained. How about using the safeStorage from Electron? I noticed that VSCode has moved from keytar to safeStorage: https://code.visualstudio.com/docs/editor/settings-sync#_troubleshooting-keychain-issues
The benefits I can identify are:
|
While developing if (!developerMode && !safeStorage.isEncryptionAvailable()) {
// warn and exit
} |
Last time I've checked safeStorage in some article it described it as not so safe compared to keytar, but maybe something changed in latest versions. I think we can switch to it eventually, but need to understand how to properly migrate so users won't need to enter their phrase manually. |
Thanks for links, I'll add the issue to the Linear. |
Have you read a contributing guide?
Current Behavior
On Linux, anytype uses keytar/libsecret to call
org.freedesktop.secrets
dbus for reading and storing the mnemonic.However, as far as I can see, there is no error handling in the code when calling
WalletCreate
andWalletRecover
directly.This might be the cause of this issue.
Expected Behavior
I am not sure whether we should prevent users from creating keys and entering Space if
org.freedesktop.secrets
dbus is unavailable, but I think there should at least be a notification.Steps To Reproduce
Remove or disable services like
gnome-keyring
on your computer, or ensure they require a password to use.Open anytype and create a key.
You will proceed to the next step without any error notification, but the mnemonic will not be displayed, and it will not be saved successfully. Upon exiting, you will be unable to re-enter the wallet and will need to create it again.
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: