Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SNan panics? #25

Closed
joshcarp opened this issue Mar 20, 2019 · 1 comment
Closed

Remove SNan panics? #25

joshcarp opened this issue Mar 20, 2019 · 1 comment

Comments

@joshcarp
Copy link
Contributor

SNan panics in functions such as signalNaN64 aren't needed due to the fact that the calling function can check if a number is a signalling Nan

Code becomes a lot simpler once panics are removed and Snan (or original weighted Nans) are returned
@joshcarp
Copy link
Contributor Author

fixed in e7229b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshcarp