v2.0: Check poh_recorder.start_slot() hasn't been dumped previously before checking it in ProgressMap. (backport of #2676) #2691
+146
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…checking it in ProgressMap. (#2676) * Check poh_recorder.start_slot() hasn't been dumped previously before checking it in progress_map. * Add more comments and put in checks for maybe_start_leader. * Update core/src/replay_stage.rs Co-authored-by: Ashwin Sekar <ashwin@solana.com> * Use a slot which I am not leader to avoid dumping my own slot panic. * Address reviewer comments. * Address reviewer comments. --------- Co-authored-by: Ashwin Sekar <ashwin@solana.com> (cherry picked from commit 053faa6)
AshwinSekar
approved these changes
Aug 22, 2024
CriesofCarrots
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible that poh_recorder.start_slot() has been dumped because of duplicate proof, in that case we would currently panic inside ProgressMap::get_propagated_stats_must_exist()
Summary of Changes
Check that start_slot still exists in ProgressMap before proceeding.
This is an automatic backport of pull request #2676 done by Mergify.