quic: use smallvec to aggregate chunks, save 1 alloc per packet #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet.
alessandrod
force-pushed
the
quic-smallvec
branch
from
9f57fa0
to
1949a46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 851 851
Lines 230937 230936 -1
=======================================
+ Hits 189217 189219 +2
+ Misses 41720 41717 -3 |
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # Cargo.lock # Cargo.toml # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs
mergify bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs
t-nelson
pushed a commit
that referenced
this pull request
Apr 11, 2024
quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs
t-nelson
pushed a commit
that referenced
this pull request
Apr 11, 2024
quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # Cargo.lock # Cargo.toml # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs
t-nelson
pushed a commit
that referenced
this pull request
Apr 11, 2024
…t (backport of #735) (#742) quic: use smallvec to aggregate chunks, save 1 alloc per packet (#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
t-nelson
pushed a commit
that referenced
this pull request
Apr 11, 2024
…t (backport of #735) (#741) quic: use smallvec to aggregate chunks, save 1 alloc per packet (#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # Cargo.lock # Cargo.toml # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…t (backport of anza-xyz#735) (anza-xyz#742) quic: use smallvec to aggregate chunks, save 1 alloc per packet (anza-xyz#735) quic: use smallvec, save one allocation per packet Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet. (cherry picked from commit 55ab7fa) # Conflicts: # programs/sbf/Cargo.lock # streamer/Cargo.toml # streamer/src/nonblocking/quic.rs Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use smallvec to hold chunks. Streams are packet-sized so we don't expect them to have many chunks. This saves us an allocation for each packet.