This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
forked from move-language/move
-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix generic function dep defect; rework function discovery approach. (#…
…199) We have previously discovered through experience that some of the model-provided information we once depended on to discover all module functions, called functions, and concrete instantiations are not always consistent or reliable. For this reason, we now take a different approach and seed our discovery with just the list of functions provided by `ModuleEnv::get_functions`. For any other called functions (this module or foreign) and for any generic instantiations, we will expand the seed frontier incrementally by gleaning the remaining information from a visitation of every function call instruction (recursively) in every seed function. This also fixes a dependence problem in the previous discovery approach where some transitively expanded generics were never seen or declared. No new tests were added as the previous generics work covers this. We now, however, can eliminate the dependence defect work around that was originally in the moption01 test case. It now runs without the work around successfully.
- Loading branch information
Showing
6 changed files
with
146 additions
and
153 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,4 @@ entry: | |
ret void | ||
} | ||
|
||
declare i8 @Test2__test2(i8, i8) | ||
|
||
declare i8 @Test1__test1(i8, i8) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters