This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
Fix generic function dep defect; rework function discovery approach. #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have previously discovered through experience that some of the model-provided information we once depended on to discover all module functions, called functions, and concrete instantiations are not always consistent or reliable. For this reason, we now take a different approach and seed our discovery with just the list of functions provided by `ModuleEnv::get_functions`. For any other called functions (this module or foreign) and for any generic instantiations, we will expand the seed frontier incrementally by gleaning the remaining information from a visitation of every function call instruction (recursively) in every seed function. This also fixes a dependence problem in the previous discovery approach where some transitively expanded generics were never seen or declared. No new tests were added as the previous generics work covers this. We now, however, can eliminate the dependence defect work around that was originally in the moption01 test case. It now runs without the work around successfully.
nvjle
changed the title
dmakarov
approved these changes
Jun 14, 2023
The differences are due to a different function output order.
ksolana
pushed a commit
to ksolana/move
that referenced
this pull request
Jun 24, 2023
…nza-xyz#199) We have previously discovered through experience that some of the model-provided information we once depended on to discover all module functions, called functions, and concrete instantiations are not always consistent or reliable. For this reason, we now take a different approach and seed our discovery with just the list of functions provided by `ModuleEnv::get_functions`. For any other called functions (this module or foreign) and for any generic instantiations, we will expand the seed frontier incrementally by gleaning the remaining information from a visitation of every function call instruction (recursively) in every seed function. This also fixes a dependence problem in the previous discovery approach where some transitively expanded generics were never seen or declared. No new tests were added as the previous generics work covers this. We now, however, can eliminate the dependence defect work around that was originally in the moption01 test case. It now runs without the work around successfully.
ksolana
pushed a commit
to ksolana/move
that referenced
this pull request
Jul 6, 2023
…nza-xyz#199) We have previously discovered through experience that some of the model-provided information we once depended on to discover all module functions, called functions, and concrete instantiations are not always consistent or reliable. For this reason, we now take a different approach and seed our discovery with just the list of functions provided by `ModuleEnv::get_functions`. For any other called functions (this module or foreign) and for any generic instantiations, we will expand the seed frontier incrementally by gleaning the remaining information from a visitation of every function call instruction (recursively) in every seed function. This also fixes a dependence problem in the previous discovery approach where some transitively expanded generics were never seen or declared. No new tests were added as the previous generics work covers this. We now, however, can eliminate the dependence defect work around that was originally in the moption01 test case. It now runs without the work around successfully.
ksolana
pushed a commit
that referenced
this pull request
Jul 17, 2023
…199) We have previously discovered through experience that some of the model-provided information we once depended on to discover all module functions, called functions, and concrete instantiations are not always consistent or reliable. For this reason, we now take a different approach and seed our discovery with just the list of functions provided by `ModuleEnv::get_functions`. For any other called functions (this module or foreign) and for any generic instantiations, we will expand the seed frontier incrementally by gleaning the remaining information from a visitation of every function call instruction (recursively) in every seed function. This also fixes a dependence problem in the previous discovery approach where some transitively expanded generics were never seen or declared. No new tests were added as the previous generics work covers this. We now, however, can eliminate the dependence defect work around that was originally in the moption01 test case. It now runs without the work around successfully.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have previously discovered through experience that some of the model-provided information we once depended on to discover all module functions, called functions, and concrete instantiations are not always consistent or reliable.
For this reason, we now take a different approach and seed our discovery with just the list of functions provided by
ModuleEnv::get_functions. For any other called functions (this module or foreign) and for any generic instantiations, we will expand the seed frontier incrementally by gleaning the remaining information from a visitation of every function call instruction (recursively) in every seed function.This also fixes a dependence problem in the previous discovery approach where some transitively expanded generics were never seen or declared.
No new tests were added as the previous generics work covers this. We now, however, can eliminate the dependence defect work around that was originally in the moption01 test case. It now runs without the work around successfully.