Fix some zh-Hant translation #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan93412
suggested changes
Oct 1, 2023
Translations-iOS/zh-Hant.xcloc/Localized Contents/zh-Hant.xliff
Outdated
Show resolved
Hide resolved
| <note>No comment provided by engineer.</note> | ||
| </trans-unit> | ||
| <trans-unit id="Add a Folder" xml:space="preserve"> | ||
| <source>Add a Folder</source> | ||
| <target>添加資料夾</target> | ||
| <target>新增資料夾</target> |
There was a problem hiding this comment.
Hmm, Apple prefers translating “Folder” to “檔案夾”. How do you think?
There was a problem hiding this comment.
I believe any of the zh-Hant users will understand 資料夾 without a second thought.
There was a problem hiding this comment.
Then it's better 新增資料夾 or 檔案夾? Sorry, I'm lost here.
There was a problem hiding this comment.
Both are acceptable. Why I did not resolve it is because of the missing of "Resolve" button on my side. 😢
There was a problem hiding this comment.
For reference this is in the Files app, "New Folder" and "untitled folder".
Translations-iOS/zh-Hant.xcloc/Localized Contents/zh-Hant.xliff
Outdated
Show resolved
Hide resolved
Translations-iOS/zh-Hant.xcloc/Localized Contents/zh-Hant.xliff
Outdated
Show resolved
Hide resolved
|
Thanks @PeterDaveHello! This translation was made using ChatGPT, so should be far from perfect. Thanks for the changes 🙌🏻 |
PeterDaveHello
force-pushed
the
Fix_zh-Hant
branch
from
d0e47f9
to
382e6ba
Compare
|
Oh, interesting 😆 |
aonez
added a commit
that referenced
this pull request
Oct 5, 2023
aonez
added a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the zh-Hant translation was copied and modified from the zh-Hans translation, and some of them are not translated properly. This patch should fix it.