Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bid / Ask Ordering mixed up in Unmarshal function? #35

Closed
payaaam opened this issue Oct 8, 2021 · 1 comment
Closed

Bid / Ask Ordering mixed up in Unmarshal function? #35

payaaam opened this issue Oct 8, 2021 · 1 comment

Comments

@payaaam
Copy link

payaaam commented Oct 8, 2021

The Kraken API has an array where you have map the fields. If this was json, this wouldn't have happened. Anyways, I think we mixed up the bid / ask in the unmarshal function.

https://docs.kraken.com/websockets/#message-spread

PR to fix: #34
@aopoltorzhicky
Copy link
Owner

Thanks for the issue. Unfortunately, I can't merge your PR because it contains some other changes. But I fixed the bug in new release v0.1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@payaaam @aopoltorzhicky