Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChunkRendererRegionMixin is incredibly inefficent #25

Open
stormdirus2 opened this issue Nov 9, 2021 · 0 comments
Open

ChunkRendererRegionMixin is incredibly inefficent #25

stormdirus2 opened this issue Nov 9, 2021 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@stormdirus2
Copy link

stormdirus2 commented Nov 9, 2021

Hey I just wanted to let you know that this mixin is unoptimized.
It runs that code for every block in every chunk region when they are rebuilt for rendering.
This affects the performance of chunk loading, mining//placing blocks, or anything else that changes the terrain.

Some potential alternatives would be to :

  • Modify the loop in ChunkRendererRegion constructor

or

  • Use FREX Api

(Suggestions from @Pyrofab)

Performance impact is potentially negligible. I just wanted to make sure you were aware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants