Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add labels to color scheme #125

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

khtruong
Copy link
Contributor

🏆 Enhancements

There was an ask to add tooltips for color schemes so users can remember which is which. I added labels to the color schemes to make tooltips more reader friendly.

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #125   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          76     76           
  Lines         970    970           
  Branches      232    232           
=====================================
  Hits          970    970
Impacted Files Coverage Δ
...et-ui-color/src/colorSchemes/categorical/google.ts 100% <ø> (ø) ⬆️
...perset-ui-color/src/colorSchemes/categorical/d3.ts 100% <ø> (ø) ⬆️
...rset-ui-color/src/colorSchemes/categorical/lyft.ts 100% <ø> (ø) ⬆️
...et-ui-color/src/colorSchemes/categorical/airbnb.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f1249...a8c7afb. Read the comment docs.

@kristw kristw merged commit 98a14a2 into apache-superset:master Mar 28, 2019
@williaster
Copy link
Contributor

nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants