Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

rename core package to connection #18

Merged
merged 1 commit into from
Oct 31, 2018
Merged

rename core package to connection #18

merged 1 commit into from
Oct 31, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 31, 2018

Rename @superset-ui/core to @superset-ui/connection

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines          89     89           
=====================================
  Hits           89     89
Impacted Files Coverage Δ
.../superset-ui-connection/test/fixtures/constants.js 100% <ø> (ø)
...superset-ui-connection/test/utils/throwIfCalled.js 100% <ø> (ø)
...uperset-ui-connection/src/callApi/parseResponse.js 100% <ø> (ø)
...ages/superset-ui-connection/src/callApi/callApi.js 100% <ø> (ø)
...et-ui-connection/src/callApi/rejectAfterTimeout.js 100% <ø> (ø)
...nnection/src/callApi/callApiAndParseWithTimeout.js 100% <ø> (ø)
...kages/superset-ui-connection/src/SupersetClient.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc2fbd...d16bf72. Read the comment docs.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure if this will have any publishing issues. it should be fine once the new package is made. Let me know if you want help replacing calls in Superset!

👍 🎉

@kristw kristw merged commit 392caca into master Oct 31, 2018
@kristw kristw deleted the kristw--rename-core branch October 31, 2018 17:15
@kristw kristw added this to the v0.3.0 milestone Nov 13, 2018
@kristw kristw added reviewable Ready for review and removed reviewable Ready for review labels Nov 13, 2018
zhaoyongjie pushed a commit to zhaoyongjie/superset-ui that referenced this pull request Sep 23, 2021
zhaoyongjie pushed a commit to zhaoyongjie/superset-ui that referenced this pull request Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants