Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: eslint issues #198

Merged
merged 1 commit into from
Jul 27, 2019
Merged

fix: eslint issues #198

merged 1 commit into from
Jul 27, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Jul 25, 2019

🐛 Bug Fix

Fix the following lint errors

/home/travis/build/apache-superset/superset-ui/packages/superset-ui-chart/src/types/Column.ts
  3:1  error  Prefer default export  import/prefer-default-export
/home/travis/build/apache-superset/superset-ui/packages/superset-ui-chart/src/types/Datasource.ts
  4:1  error  Prefer default export  import/prefer-default-export
/home/travis/build/apache-superset/superset-ui/packages/superset-ui-chart/src/types/Metric.ts
  7:1  error  Prefer default export  import/prefer-default-export
/home/travis/build/apache-superset/superset-ui/packages/superset-ui-chart/test/clients/ChartClient.test.ts
  173:7  error  Async assertions must be awaited or returned  jest/valid-expect
/home/travis/build/apache-superset/superset-ui/packages/superset-ui-chart-composition/src/tooltip/TooltipTable.tsx
  32:77  warning  'i' is defined but never used  no-unused-vars
  32:77  warning  'i' is defined but never used  @typescript-eslint/no-unused-vars

@kristw kristw requested a review from a team as a code owner July 25, 2019 22:34
@netlify
Copy link

netlify bot commented Jul 25, 2019

Deploy preview for superset-ui ready!

Built with commit 1ec5b42

https://deploy-preview-198--superset-ui.netlify.com

etr2460
etr2460 approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after fixing the 2 nits

packages/superset-ui-chart/src/types/Column.ts
@@ -1,4 +1,5 @@
/* eslint-disable no-unused-vars */
/* eslint-disable import/prefer-default-export */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can instead write /* eslint-disable no-unused-vars, import/prefer-default-export */

packages/superset-ui-chart/src/types/Metric.ts
@@ -1,4 +1,5 @@
/* eslint-disable no-unused-vars */
/* eslint-disable import/prefer-default-export */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@kristw kristw merged commit 12aeb4a into master Jul 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--fix-build branch July 27, 2019 23:22
kristw pushed a commit that referenced this pull request Apr 17, 2020
@conglei
fix(datatable): adding the consideration of padding (#198)
8b1305f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristw @etr2460