Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Add CODEOWNERS #26

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Add CODEOWNERS #26

merged 1 commit into from
Nov 7, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 7, 2018

🏠 Internal

Add CODEOWNERS to automatically assign reviewers for pull requests.
Note that the Committers team still have all admin rights. This should only help with assigning reviewers for PRs.

See https://help.github.com/articles/about-codeowners/ for more information.

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          37     37           
  Lines         325    325           
=====================================
  Hits          325    325

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3196ab1...9328e02. Read the comment docs.

@kristw kristw added the reviewable Ready for review label Nov 7, 2018
@kristw kristw self-assigned this Nov 7, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be great! 🤖 🚀

@kristw kristw merged commit b495213 into master Nov 7, 2018
@kristw kristw deleted the kristw-codeowner branch November 7, 2018 18:19
@kristw kristw added reviewable Ready for review and removed reviewable Ready for review labels Nov 13, 2018
@kristw kristw added #code-quality and removed reviewable Ready for review labels Dec 6, 2018
kristw added a commit that referenced this pull request Apr 17, 2020
* feat: line chart

* feat: implement scale extraction

* refactor: no error

* fix: handle null

* fix: nicing and demo

* fix: legend and demo

* fix: remove commented code

* fix: clean

* fix: reviewer comments

* fix: legend and series

* docs: make demos tsx

* fix: reactnode

* fix: label angle

* fix: resolve labelxxx field names

* docs: try knobs

* feat: improve axis

* refactor: combine computelayout into axisagent

* refactor: cleaner use of scale

* fix: proptypes
zhaoyongjie pushed a commit to zhaoyongjie/superset-ui that referenced this pull request Sep 23, 2021
zhaoyongjie pushed a commit to zhaoyongjie/superset-ui that referenced this pull request Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants