Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: Add force to QueryContext #445

Merged
merged 3 commits into from
May 6, 2020

Conversation

villebro
Copy link
Contributor

@villebro villebro commented May 6, 2020

🐛 Bug Fix

Currently the force parameter is missing from the QueryContext signature, making it impossible to force refresh charts. This PR adds force as an optional parameter in QueryFormData and defaults to false in QueryContext when undefined.

@rusackas @suddjian @ktmud @kristw

@villebro villebro requested a review from a team as a code owner May 6, 2020 10:25
@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/3w0exqu05
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-add-force.superset.now.sh

@villebro villebro changed the title Add force to QueryContext fix: Add force to QueryContext May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #445 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   22.20%   22.21%   +0.01%     
==========================================
  Files         264      264              
  Lines        6500     6501       +1     
  Branches      588      589       +1     
==========================================
+ Hits         1443     1444       +1     
  Misses       5020     5020              
  Partials       37       37              
Impacted Files Coverage Δ
...kages/superset-ui-query/src/types/QueryFormData.ts 100.00% <ø> (ø)
...ackages/superset-ui-query/src/buildQueryContext.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9c478...63780f6. Read the comment docs.

@kristw kristw merged commit a243911 into apache-superset:master May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants