This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Moving query module into superset-ui from incubator-superset #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Up build-config version to pick up a fix to eslint-typescript-parser - Remove usage of default exports in favor of named exports unless the export is the only thing being exported out of a module - Fixing up a few linting errors
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 99.28% 99.31% +0.02%
==========================================
Files 57 62 +5
Lines 560 584 +24
Branches 39 46 +7
==========================================
+ Hits 556 580 +24
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
kristw
approved these changes
Dec 4, 2018
…perties on the DatasourceKey class directly. - Adding tests for DatasourceKey.
williaster
approved these changes
Dec 4, 2018
kristw
added
#enhancement
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
travis build failed due to another issue, which is fixed in master. verified storybook and the new map is working correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
This PR moves query object generation code from incubator-superset to superset-ui.