This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
[core][client] mirror window.location.protocol format in config
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 7 7
Lines 68 68
=======================================
Hits 67 67
Misses 1 1
Continue to review full report at Codecov.
|
kristw
approved these changes
Sep 27, 2018
kristw
added
reviewable
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
* fix(legacy-preset-chart-nvd3): redraw bar values after legend change * fix(legacy-preset-chart-nvd3): show labels on negative bars * fix(legacy-preset-chart-nvd3): fix lint * fix(legacy-preset-chart-nvd3): improve remove
zhaoyongjie
pushed a commit
to zhaoyongjie/superset-ui
that referenced
this pull request
Sep 23, 2021
* build: migrate to nimbus * fix: eslint-disable statements * fix: conflict * fix: lint * fix: lints * fix: bump packages
zhaoyongjie
pushed a commit
to zhaoyongjie/superset-ui
that referenced
this pull request
Sep 24, 2021
* build: migrate to nimbus * fix: eslint-disable statements * fix: conflict * fix: lint * fix: lints * fix: bump packages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
When configuring
hostandprotocolinSupersetClient, it's convenient to use values fromwindow.location.This PR updates the
configforprotocolfrom expecting values like e.g.,httpandhttpsto mirror the format ofwindow.location.protocol, which includes a colon:http:orhttps:@kristw @conglei @mistercrunch