Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance test NumberFormatException bug #155

Merged
merged 5 commits into from
Sep 23, 2021
Merged

Fix performance test NumberFormatException bug #155

merged 5 commits into from
Sep 23, 2021

Conversation

DomGarguilo
Copy link
Member

Closes #154

  • Manually convert from nanoseconds to seconds to preserve precision of timing.
  • Fixed average for first set of 1-19 runs

ctubbsii
ctubbsii approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think <= 20 is more intuitive than < 21, but it's your call whether to include those changes or not. This is ready with or without that improvement.

src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java Outdated Show resolved Hide resolved
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java Outdated Show resolved Hide resolved
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java Outdated Show resolved Hide resolved
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java Outdated Show resolved Hide resolved
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java Outdated Show resolved Hide resolved
src/main/java/org/apache/accumulo/testing/performance/tests/ConditionalMutationsPT.java Outdated Show resolved Hide resolved
DomGarguilo and others added 2 commits September 23, 2021 13:43
@DomGarguilo @ctubbsii
Apply suggestions from code review
5bec2ed 
Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
@DomGarguilo
Fix rate typo in description
df1bffa
@DomGarguilo DomGarguilo merged commit 6e792d9 into apache:main Sep 23, 2021
@DomGarguilo DomGarguilo deleted the fixNumFormatBug branch September 23, 2021 20:25
Manno15 pushed a commit to Manno15/accumulo-testing that referenced this pull request Oct 1, 2021
@DomGarguilo @ctubbsii @Manno15
Fix performance test NumberFormatException bug (apache#155)
d5e204b 
* Fixed NumberFormatException
* Add constants, make runs consistent
* Make var names more meaningful

Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith-turner keith-turner keith-turner left review comments

@EdColeman EdColeman EdColeman left review comments

@Manno15 Manno15 Manno15 left review comments

@ctubbsii ctubbsii ctubbsii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConditionalMutationsPT fails with NumberFormatException
5 participants
@DomGarguilo @keith-turner @ctubbsii @EdColeman @Manno15