Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Fate Operations #421

Closed
milleruntime opened this issue Apr 11, 2018 · 4 comments
Closed

Organize Fate Operations #421

milleruntime opened this issue Apr 11, 2018 · 4 comments
Labels
blocker This issue blocks any release version labeled on it. enhancement This issue describes a new feature, improvement, or optimization.
Milestone

Comments

@milleruntime
Copy link
Contributor

The RepOs of every fate operation are ALL in the org.apache.accumulo.master.tableOps package. It is annoying to track down which RepO goes with which operation. Creating a package in o.a.a.master.tableOps for each operation would organize them nicely. This would have to be done in 2.0 since it will break serialization.

@milleruntime milleruntime added v2.0.0 enhancement This issue describes a new feature, improvement, or optimization. labels Apr 11, 2018
@milleruntime milleruntime added the blocker This issue blocks any release version labeled on it. label Jun 21, 2018
@cjmctague
Copy link
Contributor

@milleruntime Am I right by saying you want these sorted by the operations like
CREATE, DELETE, RENAME, SET_PROPERTY, REMOVE_PROPERTY, ETC.

Or do you want them grouped like CloneInfo, CloneMetadata, ClonePermissions, CloneTable, CloneZookeeper, FinishCloneTable all put into a subpackage say clone and so on for the rest of them for their respective operation.

@milleruntime
Copy link
Contributor Author

Check out bulkver1 and bulkver2

It would be like those packages but one for each operation in FateOperation

@milleruntime
Copy link
Contributor Author

So TABLE_BULK_IMPORT and TABLE_BULK_IMPORT2 are already done, that is what bulkver1 and bulkver2 cover.

@milleruntime
Copy link
Contributor Author

It would probably be easiest to start with one FateOperation and open a pull request first to make sure we are on the same page. Then you could do a second PR for the rest.

cjmctague added a commit to cjmctague/accumulo that referenced this issue Sep 26, 2018
- clean up tableOps directory to be organized by Fate operation.
cjmctague added a commit to cjmctague/accumulo that referenced this issue Sep 28, 2018
- clean up tableOps directory to be organized by Fate operation.
cjmctague added a commit to cjmctague/accumulo that referenced this issue Oct 3, 2018
- clean up tableOps directory to be organized by Fate operation.
@ctubbsii ctubbsii added this to the 2.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue blocks any release version labeled on it. enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Development

No branches or pull requests

3 participants