Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCUMULO-4060 Run a timer task to restart failed FATE repo runner thr… #52

Closed
wants to merge 1 commit into from

Conversation

joshelser
Copy link
Member

…eads.

If ZK becomes unavailable for some period of time, it's possible that the
FATE repo runner threads inside of the master will terminate without
the master itself dying.

An attempt at an implementation to "recover gracefully" when the repo-runner threads die.

…eads.

If ZK becomes unavailable for some period of time, it's possible that the
FATE repo runner threads inside of the master will terminate without
the master itself dying.
@keith-turner
Copy link
Contributor

Seems like it would be simpler to modify transaction runner and add a try/catch/log just inside the while loop.

@joshelser
Copy link
Member Author

Seems like it would be simpler to modify transaction runner and add a try/catch/log just inside the while loop.

We very well could do this as well. I was hoping to pick your brain on any worries in just eating those exceptions. I suppose in the end it's no different.

@keith-turner
Copy link
Contributor

eating those exceptions

don't just eat them, log them.

I suppose in the end it's no different.

Yeah I can't see any differences between the approaches.

@joshelser
Copy link
Member Author

Ok, thanks Keith. The only benefit I can see with what I did here is that it supports growing the number of repo runners. That's probably better done as a feature (with shrinking the number of them too), than as a bugfix.

@joshelser joshelser closed this Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants