Skip to content

Commit

Permalink
[AIRFLOW-XXXX] Remove duplication in BaseOperator docstring (#7321)
Browse files Browse the repository at this point in the history
  • Loading branch information
zuku1985 committed Feb 22, 2020
1 parent be0501b commit 7f3f666
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions airflow/models/baseoperator.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,6 @@ class derived from this one results in the creation of a task object,
only tasks *immediately* downstream of the previous task instance are waited
for; the statuses of any tasks further downstream are ignored.
:type wait_for_downstream: bool
:param queue: which queue to target when running this job. Not
all executors implement queue management, the CeleryExecutor
does support targeting specific queues.
:type queue: str
:param dag: a reference to the dag the task is attached to (if any)
:type dag: airflow.models.DAG
:param priority_weight: priority weight of this task against other task.
Expand Down Expand Up @@ -173,7 +169,9 @@ class derived from this one results in the creation of a task object,
DAGS. Options can be set as string or using the constants defined in
the static class ``airflow.utils.WeightRule``
:type weight_rule: str
:param queue: specifies which task queue to use
:param queue: which queue to target when running this job. Not
all executors implement queue management, the CeleryExecutor
does support targeting specific queues.
:type queue: str
:param pool: the slot pool this task should run in, slot pools are a
way to limit concurrency for certain tasks
Expand Down

3 comments on commit 7f3f666

@MichaelChirico
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just noticed this is still on the website:

https://airflow.apache.org/docs/stable/_api/airflow/models/dag/index.html

Not sure how often that page gets re-compiled or if it needs manual input.

FWIW the Suggest a change on this page link is dead btw

@MichaelChirico
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I guess it's the stable part of the URL that's the source of the difference, as this commit hasn't made a stable release yet.

Thanks again!

@zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented on 7f3f666 Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelChirico You're right, stable ref the laster release version, for now is 1.10.9, and latest for master in github repo. So I you find some change in documentation in master branch one day ago, but not in stable, it just not release

Please sign in to comment.