[AIRFLOW-XXXX] Remove duplication in BaseOperator docstring #7321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zuku1985 ! |
ashb
reviewed
Feb 1, 2020
| @@ -173,8 +173,6 @@ class derived from this one results in the creation of a task object, | |||
| DAGS. Options can be set as string or using the constants defined in | |||
| the static class ``airflow.utils.WeightRule`` | |||
| :type weight_rule: str | |||
| :param queue: specifies which task queue to use | |||
There was a problem hiding this comment.
Good spot! But could you please remove the other one? This one matches the position of the queue param
There was a problem hiding this comment.
@ashb I moved the one I left to the proper position. It was more descriptive to me.
zuku1985
force-pushed
the
AIRFLOW-XXXX-operator-docs
branch
from
e4b8747
to
2d1e37a
Compare
ashb
approved these changes
Feb 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #7321 +/- ##
======================================
Coverage 86.3% 86.3%
======================================
Files 871 871
Lines 40660 40660
======================================
Hits 35091 35091
Misses 5569 5569
Continue to review full report at Codecov.
|
potiuk
pushed a commit
that referenced
this pull request
Feb 25, 2020
(cherry picked from commit 7f3f666)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
kaxil
pushed a commit
that referenced
this pull request
Mar 19, 2020
(cherry picked from commit 7f3f666)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 19, 2020
) (cherry picked from commit 7f3f666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link:
Document only change, no JIRA issueMinor change in BaseOperator docs. I removed duplicated queue parameter.
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.