Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github provider #20300

Closed
1 task done
eladkal opened this issue Dec 14, 2021 · 5 comments · Fixed by #21076
Closed
1 task done

Add Github provider #20300

eladkal opened this issue Dec 14, 2021 · 5 comments · Fixed by #21076

Comments

@eladkal
Copy link
Contributor

eladkal commented Dec 14, 2021

Body

Add Github provider based on offical Python SDK https://github.com/PyGithub/PyGithub
The SDK has many objects which can be viewed at https://pygithub.readthedocs.io/en/latest/github_objects.html

It would be nice if we can create a hook that can leverage the package and allow the user to interact with it.

For example: being able to to find when file was last commited.

PR example for creating new provider can be seen on #17068

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@uranusjr
Copy link
Member

Not sure is async support is useful, but gidgethub is another solution.

@pateash
Copy link
Contributor

pateash commented Dec 16, 2021

@eladkal as far as I know LGPL-3.0 License is not compatible with Apache2 license ( we can use ApacheV2 into LGPL3 but not the otherway around), So we can't use PyGithub https://www.apache.org/licenses/GPL-compatibility.html
Also I would like to take this up.

@eladkal
Copy link
Contributor Author

eladkal commented Dec 16, 2021

@eladkal as far as I know LGPL-3.0 License is not compatible with Apache2 license ( we can use ApacheV2 into LGPL3 but not the otherway around), So we can't use PyGithub https://www.apache.org/licenses/GPL-compatibility.html Also I would like to take this up.

This is about Airflow provider. #9898 talks about it at length.
There shouldn't be a problem with providers packages.
@kaxil @potiuk can you confirm?

@potiuk
Copy link
Member

potiuk commented Dec 16, 2021

It's OK. LGPL Is ok as an optional dependency.

https://www.apache.org/legal/resolved.html#optional

@potiuk
Copy link
Member

potiuk commented Dec 16, 2021

Alll providers - by definition - are optional features of Airflow.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants