Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Operator does not support launch type "EXTERNAL" #21321

Closed
2 tasks done
094459 opened this issue Feb 4, 2022 · 8 comments · Fixed by #22093
Closed
2 tasks done

ECS Operator does not support launch type "EXTERNAL" #21321

094459 opened this issue Feb 4, 2022 · 8 comments · Fixed by #22093
Assignees
Labels
good first issue kind:feature Feature Requests provider:amazon-aws AWS/Amazon - related issues

Comments

@094459
Copy link
Contributor

094459 commented Feb 4, 2022

Description

You can run ECS tasks either on EC2 instances or via AWS Fargate, and these will run in AWS. With ECS Anywhere, you are now able to run the same ECS tasks on any host that has the ECS agent - on prem, in another cloud provider, etc. The control plane resides in ECS, but the execution of the task is managed by the ECS agent.

To launch tasks on hosts that are managed by ECS Anywhere, you need to specify a launch type of EXTERNAL. This is currently not supported by the ECS Operator. When you attempt do this, you get an error of unsupported launch type.

The current work around is to use boto3 and create a task and then run it using the correct parameters.

Use case/motivation

The ability to run your task code to support hybrid and multi-cloud orchestration scenarios.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@094459 094459 added the kind:feature Feature Requests label Feb 4, 2022
@potiuk
Copy link
Member

potiuk commented Feb 4, 2022

Maybe you would like to create a PR about it @094459 ? Sounds like an easy thing to implement.

@094459
Copy link
Contributor Author

094459 commented Feb 4, 2022

Yup, thanks @potiuk this is exactly what I plan to do. I am currently in the "planning" phase, and will be working with another developer on this. First step is going through all the detailed docs so we understand how to build Airflow from source and any other important things like style guidelines, expectations.

@potiuk
Copy link
Member

potiuk commented Feb 4, 2022

Cool. Both of you comment here when you are ready and I will assign it to you signalling to others the task is "in the making" :)

@mrichman
Copy link
Contributor

mrichman commented Feb 5, 2022

Hey @potiuk ! @094459 and I are on the case :)

@potiuk
Copy link
Member

potiuk commented Feb 5, 2022

Assigned both of you :)

@eladkal eladkal added the provider:amazon-aws AWS/Amazon - related issues label Feb 14, 2022
@094459
Copy link
Contributor Author

094459 commented Mar 8, 2022

Apologies for the long time since the last update. During the testing phase, I realised that the ECSOperator does actually support the launch type of "EXTERNAL" so this is not a bug or feature that needs to be added to the ECSOperator code (ecs.py). It would probably be beneficial to update the documentation, add a new test case and provide an updated example DAG. I have these ready to go if this is ok.

@potiuk
Copy link
Member

potiuk commented Mar 8, 2022

Go ahead!

@094459
Copy link
Contributor Author

094459 commented Mar 8, 2022

Thanks, just going through the docs carefully so I can understand the mechanisms and what is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue kind:feature Feature Requests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants