Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart - mounting-dags-from-a-private-github-repo-using-git-sync-sidecar #21970

Closed
1 of 2 tasks
schudoku opened this issue Mar 3, 2022 · 3 comments · Fixed by #26632
Closed
1 of 2 tasks

helm chart - mounting-dags-from-a-private-github-repo-using-git-sync-sidecar #21970

schudoku opened this issue Mar 3, 2022 · 3 comments · Fixed by #26632

Comments

@schudoku
Copy link

schudoku commented Mar 3, 2022

Describe the issue with documentation

doc link: https://airflow.apache.org/docs/helm-chart/stable/manage-dags-files.html#mounting-dags-from-a-private-github-repo-using-git-sync-sidecar
doc location:
"""
[...]
repo: ssh://git@github.com//.git
[...]
"""
I literally spent one working day making the helm deployment work with the git sync feature.
I prefixed my ssh git repo url with "ssh://" as written in the doc. This resulted in the git-sync container being stuck in a CrashLoopBackOff.

How to solve the problem

Only when I removed the prefix it worked correctly.

Anything else

chart version: 1.4.0
git-sync image tag: v3.1.6 (default v3.3.0)

Maybe the reason for the issue is the change of the image tag. However I want to share my experience. Maybe the doc is misleading. For me it was.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@schudoku schudoku added kind:bug This is a clearly a bug kind:documentation labels Mar 3, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 3, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

Could you please submit a fix for that?

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

It's as easy as clicking a "suggest a change on this page" and creating a PR. Airlfow is created by almost 2000 contributors and you can become one of them this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants