Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct repo example for cloning via ssh - comments in helm chart #27671

Merged

Conversation

morkot
Copy link
Contributor

@morkot morkot commented Nov 14, 2022

In values.yaml file of helm chart there are two options for the git clone url one if which doesn't work. When anyone generates values file using command helm show values apache-airflow/airflow > values.yam and uses wrong example it leads to errors in git-sync.

Related:
#21970
#26632

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Nov 14, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 14, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@morkot
Copy link
Contributor Author

morkot commented Nov 15, 2022

Hi @potiuk thanks for approving! I know it is tiny but it will save a lot of time for those who will stumble upon the same issue. Can it be merged, so I can forget about that?

@jedcunningham jedcunningham merged commit b9861f0 into apache:main Nov 15, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 15, 2022

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks @morkot! Congrats on your first commit 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants