Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status of testing of Apache Airflow Helm Chart 1.8.0rc1 #29273

Closed
23 of 28 tasks
jedcunningham opened this issue Jan 31, 2023 · 25 comments
Closed
23 of 28 tasks

Status of testing of Apache Airflow Helm Chart 1.8.0rc1 #29273

jedcunningham opened this issue Jan 31, 2023 · 25 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@jedcunningham
Copy link
Member

jedcunningham commented Jan 31, 2023 •
edited
Loading

We have a kind request for all the contributors to the latest Apache Airflow Helm Chart 1.8.0rc1.

Could you please help us to test the RC versions of the Apache Airflow Helm Chart?

Please let us know in the comment if the issue is addressed in the latest RC.

Thanks to all who contributed to the release (probably not a complete list!):
@richardbadman @ronahk @pgvishnuram @sudeepgupta90 @Jmdaming @joseph-max-coalfire @Aakcht @tseruga @JulesTriomphe @morkot @rauljmz @pierrejeambrun @csp33 @raphaelauv @rob-1126 @jedcunningham @okue @venkatnpedada @Chen-Oliver @schudoku @EricGao888 @danielhoherd @BobDu @snjypl @potiuk @ephraimbuddy
@jedcunningham jedcunningham added the kind:meta High-level information important to the community label Jan 31, 2023
@danielhoherd
Copy link
Contributor

I have validated #27848 which was easy to validate. It was just a version bump.

@EricGao888
Copy link
Member

I have validated #28858 which fixed some comments in the source code.

@Aakcht
Copy link
Contributor

Aakcht commented Feb 1, 2023

Checked #27544 , #27779 and #29032 - all good.

@sudeepgupta90
Copy link
Contributor

sudeepgupta90 commented Feb 1, 2023 via email

@csp33
Copy link
Contributor

csp33 commented Feb 1, 2023

Checked #27781
Works as expected

@pgvishnuram
Copy link
Contributor

Checked #27439 works as expected

@JulesTriomphe
Copy link
Contributor

I have spotted multiple issues:

  • There is a missing prefixing - here to cleanly render the volume mounts for the migrate-database-job, same here for the dag-processor, here, here and here for the scheduler, here and here for the triggerer, here and here for the webserver, here, here, here and here for the workers
  • Globally defined volumes are missing in the pod-template-file which will make pod spawning fail on clusters where readOnlyRootFilesystem is True and a volume for airflow home has been set globally. Workaround would be to set that volume in each system's extraVolumes and extraVolumeMounts but that would greatly reduce the functionality of global volumes and volume mounts.
  • There is a missing trailing - here to cleanly render the "airflow_dags_mount"
  • There is a missing prefixing - here to cleanly render webserver service ports, and I didn't manage to clean the rendering of the fields themselves (name aligned with the dash). The current state looks like this:
ports:

    - 
      name: airflow-ui
      port: 8080

I will try adding the missing globally defined volumes to the pod template file, deploy and then open a PR to correct this and another for the rendering issues.

@richardbadman
Copy link
Contributor

Checked #27148, works as expected

@ronahk
Copy link
Contributor

ronahk commented Feb 1, 2023 via email

@rob-1126
Copy link
Contributor

rob-1126 commented Feb 1, 2023

Checked #28041 - works as expected.

@JulesTriomphe JulesTriomphe mentioned this issue Feb 1, 2023
Closed
@jedcunningham
Copy link
Member Author

@JulesTriomphe, thanks for testing this out! Since the issue you found isn't a regression from 1.7.0, it'll end up going in the next helm chart release instead of blocking this one.

@joseph-max-coalfire
Copy link
Contributor

Tested #26945 -- looks good, working as intended 💯

This was referenced Feb 1, 2023
Merged
Merged
Merged
@JulesTriomphe
Copy link
Contributor

@jedcunningham are you planning to release a patch version sometime soon to include these bug fixes ?

@JulesTriomphe
Copy link
Contributor

Checked #27419, works as expected

@jedcunningham
Copy link
Member Author

@JulesTriomphe, I fully intend to do releases more quickly than we have in the past. So "sometime soon" meaning in the next month, yes, in the next week or so, no.

@morkot
Copy link
Contributor

morkot commented Feb 2, 2023

#27671 has been checked. Changes are there, as expected. You can tick that one off.

@JulesTriomphe
Copy link
Contributor

Very cool, thanks for the clarification @jedcunningham !

@csp33
Copy link
Contributor

csp33 commented Feb 3, 2023

Guess we can confirm that #27230, #27668, #28074 and #29074 are working✌🏻
image

@csp33
Copy link
Contributor

csp33 commented Feb 3, 2023

#27178 works as expected

@csp33
Copy link
Contributor

csp33 commented Feb 3, 2023

#27443 is also OK

@csp33
Copy link
Contributor

csp33 commented Feb 3, 2023

All good in #27625

@csp33
Copy link
Contributor

csp33 commented Feb 3, 2023 •
edited
Loading

#28813 and #28828 look good

@BobDu
Copy link
Contributor

BobDu commented Feb 3, 2023

#27178 is ok!

@jedcunningham
Copy link
Member Author

Awesome, thanks @csp33! (I'd intended to remove all those core Airflow version bumps but missed it!)

@jedcunningham
Copy link
Member Author

1.8.0 is out! Thanks everyone for taking the time to test the RC!

@potiuk potiuk added the testing status Status of testing releases label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests