Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide non-used docs attributes from Task Instance Detail #29515

Closed
1 of 2 tasks
lorenzomagni opened this issue Feb 13, 2023 · 3 comments · Fixed by #29545
Closed
1 of 2 tasks

Hide non-used docs attributes from Task Instance Detail #29515

lorenzomagni opened this issue Feb 13, 2023 · 3 comments · Fixed by #29545
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@lorenzomagni
Copy link

Description

Inside a BashOperator, I added a markdown snippet of documentation for the "Task Instance Details" of my Airflow nodes.
Now I can see my markdown, defined by the attribute "doc_md", but also

Attribute: bash_command
Attribute: doc
Attribute: doc_json
Attribute: doc_rst
Attribute: doc_yaml

I think it would look better if only the chosen type of docs would be shown in the Task Instance detail, instead of leaving the names of other attributes without anything added to them.

screenshot

Use case/motivation

I would like to see only the type of doc attribute that I chose to add to my task instance detail and hide all the others docs type.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@lorenzomagni lorenzomagni added the kind:feature Feature Requests label Feb 13, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 13, 2023

Thanks for opening your first issue here! Be sure to follow the issue template!

@josh-fell josh-fell added the area:UI Related to UI/UX. For Frontend Developers. label Feb 14, 2023
@josh-fell
Copy link
Contributor

You're right it's a little cluttered with all of those docs attributes.

@josh-fell josh-fell self-assigned this Feb 14, 2023
josh-fell added a commit to josh-fell/airflow that referenced this issue Feb 14, 2023
Closes: apache#29515

The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance.

This PR changes the attributes displayed on the page only if they have non-empty values generally.
bbovenzi pushed a commit that referenced this issue Feb 16, 2023
)

Closes: #29515

The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance.

This PR changes the attributes displayed on the page only if they have non-empty values generally.
pierrejeambrun pushed a commit that referenced this issue Mar 7, 2023
)

Closes: #29515

The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance.

This PR changes the attributes displayed on the page only if they have non-empty values generally.

(cherry picked from commit f2f6099)
pierrejeambrun pushed a commit that referenced this issue Mar 8, 2023
)

Closes: #29515

The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance.

This PR changes the attributes displayed on the page only if they have non-empty values generally.

(cherry picked from commit f2f6099)
@lorenzomagni
Copy link
Author

Sorry for the delay, I've just noticed that you took care of my issue. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants