Don't display empty rendered attrs in Task Instance Details page #29545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: apache#29515 The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance. This PR changes the attributes displayed on the page only if they have non-empty values generally.
josh-fell
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
pierrejeambrun
approved these changes
Feb 14, 2023
Yes, which is actually |
|
I think it's ok like this. Attribute are taken from (I was concerned that some attributes could be of different types, like boolean or int for instance, but it doesn't seem like so) |
bbovenzi
approved these changes
Feb 16, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
) Closes: #29515 The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance. This PR changes the attributes displayed on the page only if they have non-empty values generally. (cherry picked from commit f2f6099)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
) Closes: #29515 The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e. `doc`, `doc_json`, `doc_md`, `doc_rst`, and `doc_yaml`). This clutters the page with less useful information for the task instance. This PR changes the attributes displayed on the page only if they have non-empty values generally. (cherry picked from commit f2f6099)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #29515
The Task Instance Details page was displaying attributes which did not have a value. Mainly these were the docs attributes (i.e.
doc,doc_json,doc_md,doc_rst, anddoc_yaml). This clutters the page with less useful information for the task instance.This PR changes the attributes displayed on the page only if they have non-emptyvalues generally.
Current Task Instance Details with no doc attribute provided
New Task Instance Details with no doc or other special rendered attributes
Current Task Instance Details with
bash_commandand onlydoc_mdprovidedThere are other special-rendered like
sqlandhqlbut let's use aBashOperatoras an example.New Task Instance Details with
bash_commandand onlydoc_mdprovided