dag processor manager, add retry_db_transcation to _fetch_callbacks #30079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmicheal
requested review from
jedcunningham and
ephraimbuddy
as code owners
uranusjr
previously approved these changes
Mar 14, 2023
uranusjr
dismissed
their stale review
Wait, no, you should not use this with @provide_session
… retries to split up provide_session and retry_db_transaction
michaelmicheal
force-pushed
the
gio/add-retry-fetch-callbacks
branch
from
75260df
to
24c02c7
Compare
uranusjr
reviewed
Mar 15, 2023
michaelmicheal
requested review from
uranusjr
and removed request for
ephraimbuddy and
jedcunningham
uranusjr
approved these changes
Mar 22, 2023
|
@uranusjr good to merge? |
28 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of moving to a standalone dag processor, we discovered that when this query fails it crashes our standalone daemon (unlike the when it runs in the scheduler in the DagProcessManagerAgent)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.