Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow UI ignoring extra connection field during test connection #32890

Closed
1 of 2 tasks
genehynson opened this issue Jul 27, 2023 · 3 comments · Fixed by #32893 or #35122
Closed
1 of 2 tasks

Airflow UI ignoring extra connection field during test connection #32890

genehynson opened this issue Jul 27, 2023 · 3 comments · Fixed by #32893 or #35122
Labels
affected_version:2.6 Issues Reported for 2.6 area:core area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug

Comments

@genehynson
Copy link
Contributor

genehynson commented Jul 27, 2023

Apache Airflow version

Other Airflow 2 version (please specify below)

What happened

In Airflow 2.6.1 I can no longer use the extra field in any http based connection when testing the connection.

Inspecting the web request for testing the connection I see that the extra field is empty, even though I have data in there:

{
  "connection_id": "",
  "conn_type": "http",
  "extra": "{}"
}
image

I saw this issue which seems related. It was closed because the opener worked around the issue by creating the connection in code instead of the Airflow UI.

I couldn't find any other issues mentioning this problem.

What you think should happen instead

The extra field should be included in the test connection request.

How to reproduce

Create an http connection in the Airflow UI using at least version 2.6.1. Put any value in the extra field and test the connection while inspecting the network request. Notice that the extra field value is not supplied in the request.

Operating System

N/A

Versions of Apache Airflow Providers

N/A

Deployment

Astronomer

Deployment details

No response

Anything else

If I had to guess, I think it might be related to this PR where a json linter was added to the extra field.

Saving the connection seems to work fine, just not testing it.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@genehynson genehynson added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jul 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 27, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@eladkal eladkal added good first issue area:UI Related to UI/UX. For Frontend Developers. affected_version:2.6 Issues Reported for 2.6 and removed needs-triage label for new issues that we didn't triage yet labels Jul 28, 2023
@pankajkoti
Copy link
Member

pankajkoti commented Aug 2, 2023

Reopening this as the fix #32893 was reverted in #33032

@pankajkoti pankajkoti reopened this Aug 2, 2023
@vchiapaikeo
Copy link
Contributor

Happy to take a second look at this. Feel free to assign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.6 Issues Reported for 2.6 area:core area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Projects
None yet
4 participants