Improvement: Added JSON linter to connection edit / add UI #28583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a proposal for an improvement on the connection edit / add UI.
conn.extra
only allows valid JSON.On the UI, the widget is a simple TextArea without linting capabilities.
I have added the CodeMirror as already used by trigger dag view also on the connection edit / add UI.
This provides a better visual feedback.
Additionally when editing a connection, JSON data of conn.extra is displayed idented instead of a single line:
This is currently just a proposal and I would like to hear some feedback.