Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save codemirror content to extra textarea #32893

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

genehynson
Copy link
Contributor

Saves CodeMirror editor content to extra textarea when test-connection is invoked.

closes: #32890


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jul 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 27, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@genehynson genehynson changed the title fix: save codemirror content to textarea fix: save codemirror content to extra textarea Jul 27, 2023
@eladkal eladkal added this to the Airflow 2.6.4 milestone Jul 28, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Jul 28, 2023
@eladkal eladkal merged commit f86e3a1 into apache:main Aug 1, 2023
42 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 1, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@eladkal eladkal modified the milestones: Airflow 2.6.4, Airflow 2.7.0 Aug 1, 2023
pankajkoti added a commit to astronomer/airflow that referenced this pull request Aug 2, 2023
@pankajkoti
Copy link
Member

Sorry, I am observing issues due to this and have created a revert PR. Have mentioned the issues I am observing in the revert PR's description and comments #33032

ephraimbuddy pushed a commit that referenced this pull request Aug 2, 2023
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:bug-fix Changelog: Bug Fixes labels Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airflow UI ignoring extra connection field during test connection
5 participants