Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking task state as Failed or Success without taskinstance edit role is resulting into partial empty screen #37451

Closed
1 of 2 tasks
sreenusuuda opened this issue Feb 15, 2024 · 3 comments · Fixed by #38732
Closed
1 of 2 tasks
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug priority:low Bug with a simple workaround that would not block a release

Comments

@sreenusuuda
Copy link

Apache Airflow version

2.8.1

If "Other Airflow 2 version" selected, which one?

No response

What happened?

Marking task state as Failed or Success without task instance edit role is resulting into partial empty screen as shown below instead of Access Denied message.

What you think should happen instead?

We should show proper messaging saying user is lacking permission.

How to reproduce

  1. Create new user and assign user with can edit dags, can read dag runs, can edit dag runs permissions.
  2. Try to login with user and click on the specific Dag.
  3. Select task and try to mark it as Failed or Success.

Operating System

mac os

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@sreenusuuda sreenusuuda added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Feb 15, 2024
Copy link

boring-cyborg bot commented Feb 15, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@jscheffl jscheffl added good first issue priority:low Bug with a simple workaround that would not block a release area:UI Related to UI/UX. For Frontend Developers. and removed area:core needs-triage label for new issues that we didn't triage yet labels Feb 20, 2024
@jscheffl
Copy link
Contributor

I did a regression and can confirm this small UI glitch.
If user permissions are missing to edit task instances (needed to set state to success/failure) then the action buttons should rather be hidden to prevent the follow-up missing error handling in UI.

@RodrigoGanancia
Copy link
Contributor

Hey, can I work on this issue?

RodrigoGanancia added a commit to RodrigoGanancia/airflow that referenced this issue Apr 4, 2024
RodrigoGanancia added a commit to RodrigoGanancia/airflow that referenced this issue Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug priority:low Bug with a simple workaround that would not block a release
Projects
None yet
3 participants