Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dag trigger confirmation popup for Production Environment #38284

Closed
2 tasks done
maycuatroi opened this issue Mar 19, 2024 · 1 comment · Fixed by #38299
Closed
2 tasks done

Dag trigger confirmation popup for Production Environment #38284

maycuatroi opened this issue Mar 19, 2024 · 1 comment · Fixed by #38299
Assignees
@maycuatroi
Labels
area:webserver Webserver related Issues kind:feature Feature Requests

Comments

@maycuatroi
Copy link
Contributor

maycuatroi commented Mar 19, 2024 •
edited

Description

My team and I are currently working with Airflow, and we manage multiple environments: Development, Staging, and Production. Occasionally, we need to access the Production Airflow to read logs for data analysis. However, we've encountered an issue three times where a team member accidentally triggered a DAG in the Production environment.

I'm wondering if there is an existing solution to prevent this?

If not, I'd like to suggest a feature where if the environment is set to Production, Airflow would display a confirmation popup before triggering a DAG. This would ask the user to confirm if they indeed wish to proceed with the trigger.

Use case/motivation

To prevent accidental triggering of DAGs in the Production environment by adding an additional layer of confirmation for user actions.

What would you like to happen?

I'd like Airflow to display a confirmation popup asking for user confirmation before allowing a DAG to be triggered in the Production environment.

Related issues

No response

Are you willing to submit a PR?

Code of Conduct
@maycuatroi maycuatroi added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Mar 19, 2024
@potiuk
Copy link
Member

potiuk commented Mar 19, 2024

You can definitely propose a PR with feature like that.

maycuatroi added a commit to maycuatroi/airflow that referenced this issue Mar 19, 2024
@maycuatroi
- [apache#38284] Update Confirmation Logic for Dag status Changes on …
319dbe2 
…Sensitive Environments Like Production
@maycuatroi maycuatroi mentioned this issue Mar 19, 2024
Merged
@hussein-awala hussein-awala added area:webserver Webserver related Issues and removed needs-triage label for new issues that we didn't triage yet labels Mar 19, 2024
hussein-awala pushed a commit that referenced this issue Mar 20, 2024
@maycuatroi
[#38284] Update Confirmation Logic for Config Changes on Sensitive En…
d8f647c 
…vironments Like Production (#38299)

* - [#38284] Update Confirmation Logic for Dag status Changes on Sensitive Environments Like Production

* - Update pause/unpause confirm messages

* - Not version added yet

* - Fix static check

* - Ruff check

* Revert "- Fix static check"

This reverts commit cccfeb7.

* - Fix ruff check
utkarsharma2 pushed a commit to astronomer/airflow that referenced this issue Apr 22, 2024
@maycuatroi @utkarsharma2
[apache#38284] Update Confirmation Logic for Config Changes on Sensit…
02b998f 
…ive Environments Like Production (apache#38299)

* - [apache#38284] Update Confirmation Logic for Dag status Changes on Sensitive Environments Like Production

* - Update pause/unpause confirm messages

* - Not version added yet

* - Fix static check

* - Ruff check

* Revert "- Fix static check"

This reverts commit cccfeb7.

* - Fix ruff check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maycuatroi maycuatroi

Labels
area:webserver Webserver related Issues kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
3 participants
@potiuk @maycuatroi @hussein-awala