Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#38284] Update Confirmation Logic for Config Changes on Sensitive Environments Like Production #38299

Merged
merged 12 commits into from Mar 20, 2024

Conversation

maycuatroi
Copy link
Contributor

Description

I've added a configuration option require_confirmation_dag_change to both the config.yml and the Flask App. Its default value is False. However, when a user sets this configuration to True, the Dag screen (Dag.html) will enforce a logic that requires users to confirm before they can Trigger a DAG or Pause/UnPause a Dag.

This feature is particularly effective for teams working across multiple environments, including sensitive ones like Production.
Note: The confirmation is similar to the confirmation box displayed when deleting a Dag.

Related issue:

Test Screen

image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 19, 2024
Copy link

boring-cyborg bot commented Mar 19, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@hussein-awala hussein-awala added this to the Airflow 2.9.0 milestone Mar 19, 2024
@hussein-awala hussein-awala added the type:new-feature Changelog: New Features label Mar 19, 2024
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.
Here is the static checks doc you need to fix the failed tests.

@maycuatroi
Copy link
Contributor Author

@hussein-awala I've fixed the static check issue. Thank you for your advice.

@maycuatroi maycuatroi marked this pull request as draft March 20, 2024 11:55
@maycuatroi maycuatroi marked this pull request as ready for review March 20, 2024 12:15
@maycuatroi
Copy link
Contributor Author

@potiuk sorry for taking your time. I'm fixed the ruff check. Please approve trigger the workflow to run test. 🙆‍♂️

@hussein-awala hussein-awala merged commit d8f647c into apache:main Mar 20, 2024
47 checks passed
Copy link

boring-cyborg bot commented Mar 20, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@hussein-awala
Copy link
Member

Congrats on your first commit 🎉

utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
…ive Environments Like Production (apache#38299)

* - [apache#38284] Update Confirmation Logic for Dag status Changes on Sensitive Environments Like Production

* - Update pause/unpause confirm messages

* - Not version added yet

* - Fix static check

* - Ruff check

* Revert "- Fix static check"

This reverts commit cccfeb7.

* - Fix ruff check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dag trigger confirmation popup for Production Environment
3 participants