Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatiblity wiht xmlsec 1.3.14 for Amazon Provider #39103

Closed
1 task done
potiuk opened this issue Apr 18, 2024 · 7 comments
Closed
1 task done

Compatiblity wiht xmlsec 1.3.14 for Amazon Provider #39103

potiuk opened this issue Apr 18, 2024 · 7 comments
Labels
area:providers good first issue kind:meta High-level information important to the community provider:amazon-aws AWS/Amazon - related issues

Comments

@potiuk
Copy link
Member

potiuk commented Apr 18, 2024

Body

The xmlsec used by Amazon provider for authentication has compatiblity
issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it,
in the meantime we limitt python bindings to < 1.3.13.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label Apr 18, 2024
potiuk added a commit to potiuk/airflow that referenced this issue Apr 18, 2024
The xmlsec used by Amazon provider for authentication has compatiblity
issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it,
in the meantime we limitt python bindings to < 1.3.13.

See apache#39103
potiuk added a commit that referenced this issue Apr 18, 2024
The xmlsec used by Amazon provider for authentication has compatiblity
issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it,
in the meantime we limitt python bindings to < 1.3.13.

See #39103
potiuk added a commit that referenced this issue Apr 18, 2024
The xmlsec used by Amazon provider for authentication has compatiblity
issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it,
in the meantime we limitt python bindings to < 1.3.13.

See #39103

(cherry picked from commit cd88887)
@potiuk
Copy link
Member Author

potiuk commented Apr 19, 2024

cc: @ferruzzi @vincbeck might be worth looking at

utkarsharma2 pushed a commit to astronomer/airflow that referenced this issue Apr 22, 2024
…he#39104)

The xmlsec used by Amazon provider for authentication has compatiblity
issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it,
in the meantime we limitt python bindings to < 1.3.13.

See apache#39103
@potiuk potiuk changed the title Compatiblity wiht libxmlsec 1.3.14 for Amazon Provider Compatiblity wiht xmlsec 1.3.14 for Amazon Provider May 7, 2024
@ferruzzi
Copy link
Contributor

ferruzzi commented May 9, 2024

@potiuk - I'm sorry, I got distracted by a shiny new thing and completely forgot about this after you tagged me

@jedcunningham - Thanks for fixing it.

@potiuk
Copy link
Member Author

potiuk commented May 10, 2024

Fixed by #39103

@potiuk potiuk closed this as completed May 10, 2024
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this issue May 10, 2024
…he#39104)

The xmlsec used by Amazon provider for authentication has compatiblity
issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it,
in the meantime we limitt python bindings to < 1.3.13.

See apache#39103
@jedcunningham
Copy link
Member

Just for posterity: I did nothing to fix it (I just removed the pin), but 1.3.14 no longer exhibits a problem.

@vitaliyf
Copy link

@jedcunningham that's because xmlsec project uploaded binary wheels for 1.3.14 (see recent comments in xmlsec/python-xmlsec#316) so perhaps the pin inside airflow should be removed now, since they are expected to do that going forward.

We are actually running into problems with 1.3.13 that .14 is meant to address, so airflow's pin is preventing that upgrade.

@potiuk
Copy link
Member Author

potiuk commented May 12, 2024

@jedcunningham that's because xmlsec project uploaded binary wheels for 1.3.14 (see recent comments in xmlsec/python-xmlsec#316) so perhaps the pin inside airflow should be removed now, since they are expected to do that going forward.

We are actually running into problems with 1.3.13 that .14 is meant to address, so airflow's pin is preventing that upgrade.

Yes. This is what we did.

@vitaliyf
Copy link

vitaliyf commented May 12, 2024

@potiuk ah yes, I think I got confused while looking through code in your fork instead of apache/airflow 🤦. Thank you!

For posterity: pin removed in #39534 and should be released in apache-airflow-providers-amazon version > 8.21.0

kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jul 19, 2024
The xmlsec used by Amazon provider for authentication has compatiblity
issue with libxmlsec 1.2.* that is used by default in debian bookworm.

We should investigate if/howe we can upgrade our images to support it,
in the meantime we limitt python bindings to < 1.3.13.

See apache/airflow#39103

(cherry picked from commit cd888870ba1b95c20208b1c87d337cd2418e1dc1)

GitOrigin-RevId: 789051c41accb2e90e0e476b3606873767139c59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers good first issue kind:meta High-level information important to the community provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

No branches or pull requests

5 participants